Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: introduces chat_max_direct_message_users setting #18997

Merged
merged 3 commits into from Nov 15, 2022
Merged

FEATURE: introduces chat_max_direct_message_users setting #18997

merged 3 commits into from Nov 15, 2022

Conversation

jjaffeux
Copy link
Contributor

This setting limits the number of users in a direct message. 0 means you can only create a direct message with yourself.

@jjaffeux
FEATURE: introduces chat_max_direct_message_users setting
f660b23 
This setting limits the number of users in a direct message. 0 means you can only create a direct message with yourself.
@github-actions github-actions bot added the chat PRs which include a change to Chat plugin label Nov 13, 2022
@jjaffeux
Copy link
Contributor Author

jjaffeux commented Nov 13, 2022 •
edited

@mcwumbly could you have a look at the copy here next week please? Let me know if you need help

mcwumbly
mcwumbly reviewed Nov 13, 2022
View reviewed changes
Copy link
Contributor

@mcwumbly mcwumbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple small suggestions for the copy

plugins/chat/config/locales/server.en.yml Outdated Show resolved Hide resolved
plugins/chat/config/locales/server.en.yml Outdated Show resolved Hide resolved
jjaffeux and others added 2 commits November 13, 2022 19:54
@jjaffeux @mcwumbly
Update plugins/chat/config/locales/server.en.yml
49bba72 
Co-authored-by: David McClure <dave@xerotrope.org>
@jjaffeux @mcwumbly
Update plugins/chat/config/locales/server.en.yml
4c7c781 
Co-authored-by: David McClure <dave@xerotrope.org>
martin-brennan
martin-brennan approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@martin-brennan martin-brennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, the comments are only minor things and are not critical to change

@jjaffeux jjaffeux merged commit 59cb0b6 into discourse:main Nov 15, 2022
@jjaffeux jjaffeux deleted the chat/chat-max-direct-message-users branch November 15, 2022 09:40
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/add-option-to-disable-user-user-chat/228046/39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcwumbly mcwumbly mcwumbly left review comments

@martin-brennan martin-brennan martin-brennan approved these changes

@romanrizzi romanrizzi romanrizzi approved these changes

Assignees
No one assigned
Labels
chat PRs which include a change to Chat plugin
Milestone
No milestone
5 participants
@jjaffeux @discoursebot @martin-brennan @mcwumbly @romanrizzi